Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native: fix contrast ratio to meet WCAG AA guidelines #2325

Merged
merged 1 commit into from Jan 29, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jan 25, 2023

Before

The red #define _Py_SHARED_SHIFT 2 shown here, with class="cp" is #cd2828:

image

Has a contrast ratio of 3.04 which doesn't meet the WCAG AA minimum of 4.5:

image

image

And is flagged by Lighthouse:

image

After

Using Google's suggestion of #ff3a3a increases it to 4.59:

image

image

(For comparison, the AAA suggestion of #ff8888 is a bit pale, so let's go for AA.)

AAA

image

@birkenfeld
Copy link
Member

Works for me. Thanks!

@birkenfeld birkenfeld merged commit 4d8bca5 into pygments:master Jan 29, 2023
@hugovk hugovk deleted the fix-contrast branch January 29, 2023 17:27
@Anteru Anteru added this to the 2.15.0 milestone Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants