Native: fix contrast ratio to meet WCAG AA guidelines #2325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
The red
#define _Py_SHARED_SHIFT 2
shown here, withclass="cp"
is#cd2828
:Has a contrast ratio of 3.04 which doesn't meet the WCAG AA minimum of 4.5:
And is flagged by Lighthouse:
After
Using Google's suggestion of
#ff3a3a
increases it to 4.59:(For comparison, the AAA suggestion of
#ff8888
is a bit pale, so let's go for AA.)AAA