PHP: 8.x keywords

[ancarda]

This is part of the work required to get PHP 8.x support in Pygments. There is something else that needs to be added onto this patch that I couldn't figure out.

The file pygments/lexers/_php_builtins.py needs to be regenerated as there are several new functions in the standard library, such as str_starts_with (8.0) and array_is_list (8.1). I tried to run it locally after installing requirements.txt with Pip, but I keep getting ModuleNotFoundError. I'm not a Python developer, what do I need to do to get this to rebuild?

[birkenfeld]

A full error message would be helpful. Which module raises ModuleNotFoundError?

[ancarda]

Sorry, that was awful of me for not including the error message.

I'm trying to execute the file directly. I don't know if this is the right thing to do or not.

% python3 --version
Python 3.8.8

% pip3 --version
pip 21.0.1 from /opt/anaconda3/lib/python3.8/site-packages/pip (python 3.8)

% pip3 install -r requirements.txt 
Requirement already satisfied: pytest-cov in /opt/anaconda3/lib/python3.8/site-packages (from -r requirements.txt (line 1)) (3.0.0)
Requirement already satisfied: pytest-randomly in /opt/anaconda3/lib/python3.8/site-packages (from -r requirements.txt (line 2)) (3.11.0)
Requirement already satisfied: pytest>=6.0 in /opt/anaconda3/lib/python3.8/site-packages (from -r requirements.txt (line 3)) (6.2.3)
[...omitted...]

% python3 pygments/lexers/_php_builtins.py
Traceback (most recent call last):
  File "pygments/lexers/_php_builtins.py", line 4683, in <module>
    from urllib.request import urlretrieve
  File "/opt/anaconda3/lib/python3.8/urllib/request.py", line 88, in <module>
    import http.client
  File "/opt/anaconda3/lib/python3.8/http/client.py", line 71, in <module>
    import email.parser
ModuleNotFoundError: No module named 'email.parser'; 'email' is not a package

[birkenfeld]

Oh right, this is due to the pygments/lexers/email.py being imported instead of the standard module. You can run the script with python3 -I to avoid having the path of the script in the search path.

[birkenfeld]

OK, since there were a few more snags, I've updated the file in #2056 - can you check if it matches what you'd expect?

[ancarda]

I'm pretty sure readonly is in the right place, however there's two places where switch is defined (Keyword and Keyword.Declaration). Is there a way I can test this to make sure it works? Match works just like switch:

switch ($var) {
  case 'a':
    $result = "some value";
    break;
  case 'b':
    $result = "some other value";
    break;
}

// can be replaced with

$result = match ($var) {
  'a' => "some value",
  'b' => "some other value",
};

[birkenfeld]

I don't see the other place? In any case, this LGTM.