Fix requesting urls containing parameters with parameters dict

[EnricoMi]

Requesting an url that contains parameters (query part of the url) did not support giving a parameters dict:

Requester.requestJson(verb, "https://api.github.com/?per_page=10", {"per_page": 20})

Now, parameters given in the URL have precedence over the dict.

Iterating over reversed PaginatedList is affected by this.

Fixes #1136.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.74%. Comparing base (e4106e0) to head (ae187c7).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2929   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         147      147           
  Lines       14978    14984    +6     
=======================================
+ Hits        14491    14497    +6     
  Misses        487      487           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JLLeitschuh]

Why allow duplicate request parameters at all, why not throw an exception?

If we're doing this internally, this seems like a bug?

[EnricoMi]

You are right, calling this method this way does not make much sense. But the code path that ends up in this situation is complex. Other code paths might suffer from the same issue, and it is not trivial to identify those.

It is expected that the values of the parameters are identical, so this is the right thing to do in that situation. I could throw an exception when parameter values contradict. But then this becomes a breaking change for some people where this just behaved incorrectly.

[Felixoid]

Hello. Is there a chance we can have it merged?

[EnricoMi]

@JLLeitschuh you are right, now add_parameters_to_url gives precedence to the given parameters and overwrites params that exist in the url. The code path that produced the conflict now removes all params from parameters that are contained in the url, giving precedence in that particular situation only (which is the right thing to do there).