Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building PyGithub with extra directories in source root #2894

Merged
merged 1 commit into from Feb 5, 2024

Conversation

treee111
Copy link
Contributor

@treee111 treee111 commented Feb 5, 2024

@treee111
Copy link
Contributor Author

treee111 commented Feb 5, 2024

feel free to test if this also works in your environment @kloczek

@EnricoMi EnricoMi changed the title fixes a temporary directory in source tree to crash building PyGithub Fix building PyGithub with extra directories in source root Feb 5, 2024
Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi
Copy link
Collaborator

EnricoMi commented Feb 5, 2024

Tested locally, fixes the issue.

@EnricoMi EnricoMi merged commit 4d46173 into PyGithub:main Feb 5, 2024
15 checks passed
@EnricoMi
Copy link
Collaborator

EnricoMi commented Feb 5, 2024

@treee111 thanks for fixing this!

@kloczek
Copy link

kloczek commented Feb 5, 2024

feel free to test if this also works in your environment @kloczek

Just tested that and it works as expected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.2.0] Extra directory in source tree trashes build
3 participants