Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create release with optional name and message when generate_release_notes is true #2868

Merged
merged 18 commits into from Mar 21, 2024

Conversation

heitorpolidoro
Copy link
Contributor

@heitorpolidoro heitorpolidoro commented Jan 5, 2024

Name and Message are not required when generate_release_notes it true in the API: https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release

Broke if you want to use generate_release_notes without passing name or message to generate automatically

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.71%. Comparing base (0b8435f) to head (75ddd0e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2868   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files         147      147           
  Lines       14877    14881    +4     
=======================================
+ Hits        14388    14392    +4     
  Misses        489      489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heitorpolidoro heitorpolidoro deleted the branch PyGithub:main January 5, 2024 13:32
@heitorpolidoro heitorpolidoro deleted the main branch January 5, 2024 13:32
@heitorpolidoro heitorpolidoro restored the main branch January 5, 2024 13:32
@heitorpolidoro heitorpolidoro reopened this Jan 5, 2024
github/Repository.py Outdated Show resolved Hide resolved
github/Repository.py Outdated Show resolved Hide resolved
github/Repository.py Outdated Show resolved Hide resolved
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heitorpolidoro
Copy link
Contributor Author

Sorry for the delay in fixing

Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work for you?

github/Repository.py Outdated Show resolved Hide resolved
@EnricoMi EnricoMi changed the title name and message are not required when generate_release_notes it true Make name and message optional when generate_release_notes is true when creating release Mar 2, 2024
heitorpolidoro and others added 3 commits March 4, 2024 15:47
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi EnricoMi changed the title Make name and message optional when generate_release_notes is true when creating release Create release with optional name and message when generate_release_notes is true Mar 21, 2024
@EnricoMi EnricoMi merged commit d65fc30 into PyGithub:main Mar 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants