New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add docformatter to precommit #2614
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2614 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 147 147
Lines 14885 14885
=======================================
Hits 14396 14396
Misses 489 489 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I general, the formatting changes look good to me, but there is some unexpected spelling change.
github/Repository.py
Outdated
: : class:`null <github.GithubObject.NotSet>`:, 'commit' | ||
: : class:`Commit <github.Commit.Commit>`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, this also seems wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I think in this case the docstring shall be marked with r to be parsed as RST
3835a6c
to
c18fdca
Compare
c18fdca
to
b30ea57
Compare
sorry, wrong reply |
Seems like your message is unrelated to actual state, please update it accordingly |
I'm running pre-commit on all files at latest commit b30ea57 of this PR. |
@EnricoMi applied after all the pyi were merged and all seems fine now, pls check it again :) |
@EnricoMi mind pls checking again 🙏 |
@EnricoMi is there anything I can do to help it land? 🦩 |
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
@EnricoMi mind kindly review again, pls 🙏 |
Please rebase and rerun again. |
@EnricoMi merged the |
@EnricoMi thank you, it was long and really appreciate your patience =) |
let's get unify the docstrings
cc: @EnricoMi