Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PaginatedList.pyi back to source #2555

Merged
merged 7 commits into from Jun 20, 2023
Merged

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Jun 16, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023

Codecov Report

Patch coverage: 93.10% and project coverage change: +0.21 🎉

Comparison is base (b6258f4) 98.19% compared to head (3591bd4) 98.41%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2555      +/-   ##
==========================================
+ Coverage   98.19%   98.41%   +0.21%     
==========================================
  Files         128      128              
  Lines       11754    12814    +1060     
==========================================
+ Hits        11542    12611    +1069     
+ Misses        212      203       -9     
Impacted Files Coverage Δ
github/Requester.py 97.28% <ø> (+0.01%) ⬆️
github/PaginatedList.py 97.84% <93.10%> (-1.39%) ⬇️

... and 111 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

github/PaginatedList.py Outdated Show resolved Hide resolved
github/PaginatedList.py Outdated Show resolved Hide resolved
github/PaginatedList.py Outdated Show resolved Hide resolved
trim21 and others added 2 commits June 19, 2023 06:54
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
github/PaginatedList.py Outdated Show resolved Hide resolved
github/PaginatedList.py Show resolved Hide resolved
github/PaginatedList.py Outdated Show resolved Hide resolved
github/Requester.py Show resolved Hide resolved
github/Requester.py Show resolved Hide resolved
Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi EnricoMi changed the title merge PaginatedList.pyi back to source Merge PaginatedList.pyi back to source Jun 19, 2023
@EnricoMi
Copy link
Collaborator

@trim21 ready to merge?

@trim21
Copy link
Contributor Author

trim21 commented Jun 20, 2023

yes

@trim21
Copy link
Contributor Author

trim21 commented Jun 20, 2023

I don't have write permission 🙂

@EnricoMi EnricoMi merged commit cb50dec into PyGithub:master Jun 20, 2023
10 checks passed
@EnricoMi
Copy link
Collaborator

Thanks!

@trim21 trim21 deleted the page-list branch July 18, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants