Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type stub for get_project_column #2502

Merged
merged 2 commits into from Jun 21, 2023

Conversation

Railslide
Copy link
Contributor

get_project_column was missing from the type stubs, so both mypy and pyright complained when using the method.

Co-Authored: Attila Dulovics <dulovicsattila@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (300c501) 98.77% compared to head (ba78859) 98.77%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2502   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         117      117           
  Lines       11674    11674           
=======================================
  Hits        11531    11531           
  Misses        143      143           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi EnricoMi merged commit d514222 into PyGithub:main Jun 21, 2023
10 checks passed
@Railslide Railslide deleted the get-project-column-type-stub branch June 26, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants