Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GithubIntegration that uses expiring jwt #2460

Merged
merged 1 commit into from May 5, 2023

Conversation

EnricoMi
Copy link
Collaborator

@EnricoMi EnricoMi commented Mar 19, 2023

Pull request #1986 substantially rewrote GithubIntegration, which lost using a fresh jwt token when calling get_access_token. This reverts that change.

Fixes #2431.

This does not fix expiring JWT tokens when iterating over pages returned by get_installations(), or calling get_repos() on returned Installations. This will require a bigger rework.

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (300c501) 98.77% compared to head (d96557b) 98.77%.

❗ Current head d96557b differs from pull request most recent head 45e026e. Consider uploading reports for the commit 45e026e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2460   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         117      117           
  Lines       11674    11674           
=======================================
  Hits        11531    11531           
  Misses        143      143           
Impacted Files Coverage Δ
github/GithubIntegration.py 96.61% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@EnricoMi EnricoMi changed the title Fix GithubIntegration using exiring jwt Fix GithubIntegration using expiring jwt Mar 20, 2023
@EnricoMi EnricoMi changed the title Fix GithubIntegration using expiring jwt Fix GithubIntegration that uses expiring jwt Mar 20, 2023
Copy link
Collaborator

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi
Copy link
Collaborator Author

@s-t-e-v-e-n-k can you please approve?

@EnricoMi EnricoMi merged commit a343100 into PyGithub:master May 5, 2023
7 checks passed
@EnricoMi EnricoMi deleted the fix-app-auth branch May 5, 2023 12:55
EnricoMi added a commit that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

401 unauthorized after upgrading to 1.58.0
3 participants