Fix GithubIntegration that uses expiring jwt #2460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #1986 substantially rewrote
GithubIntegration
, which lost using a fresh jwt token when callingget_access_token
. This reverts that change.Fixes #2431.
This does not fix expiring JWT tokens when iterating over pages returned by
get_installations()
, or callingget_repos()
on returnedInstallations
. This will require a bigger rework.