Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RLock from Requester #2446

Merged
merged 1 commit into from Mar 14, 2023
Merged

Conversation

EnricoMi
Copy link
Collaborator

@EnricoMi EnricoMi commented Mar 5, 2023

Each process is refreshing its own copy of the token individually, with or without lock.

Fixes #2436.
Fixes #2430.

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (def5223) 98.77% compared to head (15e7096) 98.77%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2446      +/-   ##
==========================================
- Coverage   98.77%   98.77%   -0.01%     
==========================================
  Files         117      117              
  Lines       11674    11671       -3     
==========================================
- Hits        11531    11528       -3     
  Misses        143      143              
Impacted Files Coverage Δ
github/Requester.py 97.41% <50.00%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@s-t-e-v-e-n-k
Copy link
Collaborator

You need the Fixes in the commit body for GitHub to automatically close the issues, once that's done we can merge this.

@EnricoMi
Copy link
Collaborator Author

EnricoMi commented Mar 6, 2023

You need the Fixes in the commit body for GitHub to automatically close the issues, once that's done we can merge this.

The "Fixes" in the pull request description do as well.

@reconman
Copy link

reconman commented Mar 6, 2023

The "Fixes" in the pull request description do as well.

Can confirm, Github even says so on the right side of the PR:
image

@s-t-e-v-e-n-k
Copy link
Collaborator

I will admit I've been waiting for @dblanchette to chime in here, but let's move on.

@s-t-e-v-e-n-k s-t-e-v-e-n-k merged commit 45f3d72 into PyGithub:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GithubObjects are no longer serializable with pickle 1.58 is not compatible with AWS Lambda
5 participants