Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add crypto extras to pyjwt, which pulls in cryptogaphy package #2443

Merged
merged 4 commits into from Mar 14, 2023
Merged

Add crypto extras to pyjwt, which pulls in cryptogaphy package #2443

merged 4 commits into from Mar 14, 2023

Conversation

EnricoMi
Copy link
Collaborator

@EnricoMi EnricoMi commented Mar 1, 2023 •
edited

Fixes #2441.

EnricoMi
EnricoMi commented Mar 1, 2023
View reviewed changes
test-requirements.txt
@@ -1,4 +1,3 @@
cryptography
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why the test worked without pyjwt[crypto] in setup.py.

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (def5223) 98.77% compared to head (2a2995a) 98.77%.

❗ Current head 2a2995a differs from pull request most recent head 55abb16. Consider uploading reports for the commit 55abb16 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2443   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         117      117           
  Lines       11674    11674           
=======================================
  Hits        11531    11531           
  Misses        143      143
Impacted Files Coverage Δ
github/Requester.py 97.43% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@s-t-e-v-e-n-k s-t-e-v-e-n-k merged commit 554b2b2 into PyGithub:master Mar 14, 2023
7 checks passed
@jcfr jcfr mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-t-e-v-e-n-k s-t-e-v-e-n-k s-t-e-v-e-n-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cryptography as dependency (for app-based auth)
3 participants
@EnricoMi @codecov-commenter @s-t-e-v-e-n-k