Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass requester base URL to integration (#2420) #2425

Merged
merged 1 commit into from Feb 23, 2023

Conversation

bluek1te
Copy link
Contributor

@bluek1te bluek1te commented Feb 16, 2023

Base URL was not passed into GithubIntegration leaving it to use the one defined in const. Fixes #2420.

@EnricoMi
Copy link
Collaborator

Excellent, thanks for picking this up!

Btw., is there a way to test this?

@s-t-e-v-e-n-k
Copy link
Collaborator

Oh wow, I've never seen that particular Github actions failure. @dblanchette what do you think, since you're rather familiar with that code?

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Base: 98.77% // Head: 98.77% // No change to project coverage 👍

Coverage data is based on head (bdceae2) compared to base (def5223).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2425   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         117      117           
  Lines       11674    11674           
=======================================
  Hits        11531    11531           
  Misses        143      143           
Impacted Files Coverage Δ
github/Requester.py 97.43% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bluek1te
Copy link
Contributor Author

Looks like checks passed after I rebased the code

Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi EnricoMi changed the title pass requester base URL to integration (#2420) Pass requester base URL to integration (#2420) Feb 23, 2023
@EnricoMi EnricoMi merged commit 5033f5f into PyGithub:master Feb 23, 2023
@EnricoMi EnricoMi added this to the Version 1.58.1 milestone Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#1986 seems to break setting GitHub base URL
4 participants