Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue the PR #1899 #2386

Merged
merged 4 commits into from Jan 30, 2023
Merged

Continue the PR #1899 #2386

merged 4 commits into from Jan 30, 2023

Conversation

Felixoid
Copy link
Contributor

Hello. I'd like to have the #1899 finished and #1898 fixed.

The release payload has assets and it's a bit painful to have other unnecessary requests spent on getting the assets

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Base: 98.75% // Head: 98.74% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (af9e704) compared to base (6c53e54).
Patch coverage: 71.42% of modified lines in pull request are covered.

❗ Current head af9e704 differs from pull request most recent head 409358f. Consider uploading reports for the commit 409358f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2386      +/-   ##
==========================================
- Coverage   98.75%   98.74%   -0.02%     
==========================================
  Files         115      115              
  Lines       11588    11595       +7     
==========================================
+ Hits        11444    11449       +5     
- Misses        144      146       +2     
Impacted Files Coverage Δ
github/GitRelease.py 98.14% <71.42%> (-1.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Felixoid
Copy link
Contributor Author

Codecov hasn't updated the comment, the coverage is not changed actually, see the View full report at Codecov.

@Felixoid
Copy link
Contributor Author

Dear @sfdye and @s-t-e-v-e-n-k, is the project active? Can you be so nice and review the PR, please?

@Felixoid
Copy link
Contributor Author

I think I've mentioned Steve accidentally. But maybe @jacquev6, @JPWKU or @adamtheturtle could help?

@sfdye sfdye merged commit 7cf3dfc into PyGithub:master Jan 30, 2023
@Felixoid Felixoid deleted the issue1898 branch January 31, 2023 09:15
@Felixoid
Copy link
Contributor Author

Thanks a lot!

Do you need some help in voluntarily reviewing PRs maybe? I am a little bit into the code right now, since starting using it intensively in our CI/CD system. I can provide some time into the code base.

@sfdye
Copy link
Member

sfdye commented Jan 31, 2023

@Felixoid Help is always welcome. Feel free to move the project forward in any way.

@Felixoid
Copy link
Contributor Author

Felixoid commented Feb 1, 2023

Thanks, I didn't know one can approve PR w/ just default permissions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants