Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for workflow jobs and steps #1951

Merged
merged 4 commits into from Jun 20, 2023
Merged

Add support for workflow jobs and steps #1951

merged 4 commits into from Jun 20, 2023

Conversation

Tenzer
Copy link
Contributor

@Tenzer Tenzer commented May 14, 2021

This relates to GitHub Actions and #1373.

These new features expose information about the jobs run for a workflow, and each of the steps in those jobs.

I also made a small fix to the add_attribute.py script, as it added assertions that didn't work with datetime objects. I think it may have been leftover from the Python 2 support. Disabling the assertion instead made it work and also made the generated code match what I could see was used elsewhere in the project.

Please let me know if there's anything missing or any adjustments that need to be made.

Copy link
Collaborator

@s-t-e-v-e-n-k s-t-e-v-e-n-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly this is looking good, just missing the type information (pyi files)

github/WorkflowJob.py Outdated Show resolved Hide resolved
github/WorkflowStep.py Outdated Show resolved Hide resolved
scripts/add_attribute.py Outdated Show resolved Hide resolved
tests/WorkflowJob.py Outdated Show resolved Hide resolved
@Tenzer
Copy link
Contributor Author

Tenzer commented Jun 28, 2021

Thanks for taking a look at this. I have added the missing type annotations now.

@seemethere
Copy link

Is there any update to this?

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 8, 2022
@stale stale bot closed this Apr 16, 2022
@Tenzer
Copy link
Contributor Author

Tenzer commented Apr 16, 2022

Is there any chance this could be incorporated?

@antoinerrr
Copy link

Why is this PR closed ?

@crackedupcorson
Copy link

Is there any chance this feature could be added? I don't see WorkflowJob in this package currently.

@Tenzer
Copy link
Contributor Author

Tenzer commented Dec 14, 2022

@sfdye I don't know if you have seen this PR, but is it possible it could be re-opened and merged?

@sfdye sfdye reopened this Dec 15, 2022
@stale stale bot removed the stale label Dec 15, 2022
@sfdye
Copy link
Member

sfdye commented Dec 15, 2022

We need to resolve the merge conflicts

@Tenzer
Copy link
Contributor Author

Tenzer commented Dec 15, 2022

They have been sorted out now.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Patch coverage: 92.07% and project coverage change: +0.26 🎉

Comparison is base (cb50dec) 98.41% compared to head (4d09b81) 98.68%.

❗ Current head 4d09b81 differs from pull request most recent head 0aa891e. Consider uploading reports for the commit 0aa891e to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1951      +/-   ##
==========================================
+ Coverage   98.41%   98.68%   +0.26%     
==========================================
  Files         128      119       -9     
  Lines       12814    11835     -979     
==========================================
- Hits        12611    11679     -932     
+ Misses        203      156      -47     
Impacted Files Coverage Δ
github/WorkflowStep.py 77.08% <77.08%> (ø)
github/WorkflowRun.py 97.58% <85.71%> (-2.42%) ⬇️
github/WorkflowJob.py 99.08% <99.08%> (ø)

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yongzhang
Copy link

can't wait it to be released

@JakobEdding
Copy link

JakobEdding commented Mar 15, 2023

Thanks for building this @Tenzer. Is there any estimate about when this will be merged/released?

github/WorkflowJob.py Show resolved Hide resolved
github/WorkflowJob.py Show resolved Hide resolved
@EnricoMi
Copy link
Collaborator

@Tenzer I have added replay data for the logs_url call (and updated the other WorkflowJobs calls).

Copy link

@davejames davejames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done some functional testing on this and am currently using it. LGTM and hope it's merged soon

@FearlessHyena
Copy link

When will this be merged?

Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve once these suggestions are incorporated.

tests/WorkflowJob.py Show resolved Hide resolved
github/WorkflowJob.py Show resolved Hide resolved
github/WorkflowJob.py Show resolved Hide resolved
EnricoMi

This comment was marked as duplicate.

Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sfdye sfdye merged commit 804c310 into PyGithub:master Jun 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet