From 287dada236dbbeacbb753848d5d86158f2fa1917 Mon Sep 17 00:00:00 2001 From: Daniel McCloy Date: Fri, 15 Sep 2023 09:29:39 -0500 Subject: [PATCH 1/2] use project version (not theme version) in banner --- src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js b/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js index e7f26dfb9..c34ca831b 100644 --- a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js +++ b/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js @@ -429,7 +429,7 @@ function populateVersionSwitcher(data, versionSwitcherBtns) { * @param {Array} data The version data used to populate the switcher menu. */ function showVersionWarningBanner(data) { - const version = DOCUMENTATION_OPTIONS.theme_version; + var version = DOCUMENTATION_OPTIONS.VERSION; // figure out what latest stable version is var preferredEntries = data.filter((entry) => entry.preferred); if (preferredEntries.length !== 1) { @@ -473,6 +473,8 @@ function showVersionWarningBanner(data) { bold.innerText = "an unstable development version"; } else if (versionsAreComparable && compare(version, preferredVersion, "<")) { bold.innerText = `an old version (${version})`; + } else if (!version) { + bold.innerText = "an unknown version"; // e.g., an empty string } else { bold.innerText = `version ${version}`; } From 37eb470b5a23cc3b86dc58821e38bbf34b9cbcd6 Mon Sep 17 00:00:00 2001 From: Daniel McCloy Date: Mon, 18 Sep 2023 11:28:43 -0500 Subject: [PATCH 2/2] change default text on version switcher button --- .../theme/pydata_sphinx_theme/components/version-switcher.html | 2 +- tests/test_build/navbar_switcher.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html index 974aa8c87..5d07b9336 100644 --- a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html +++ b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html @@ -4,7 +4,7 @@ document.write(`