Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some links in the left mobile sidebar act like links in dropdown #1735

Closed
gabalafou opened this issue Mar 11, 2024 · 0 comments · Fixed by #1771
Closed

Some links in the left mobile sidebar act like links in dropdown #1735

gabalafou opened this issue Mar 11, 2024 · 0 comments · Fixed by #1771
Labels
tag: accessibility Issues related to accessibility issues or efforts

Comments

@gabalafou
Copy link
Collaborator

It might be worth following up some of the discussion in #1604, so that we can have a fix that is less of a hack.

Originally posted by @gabalafou in #1564 (comment)

The same markup is generated for the links in the mobile sidebar as in the desktop header nav bar.

Since the markup was originally written for the header nav bar, it carries over some assumptions to the mobile sidebar that have to be addressed with CSS and JS (for example #1604). Perhaps it's worth a slight refactor.
@gabalafou gabalafou mentioned this issue Mar 11, 2024
Merged
@trallard trallard added the tag: accessibility Issues related to accessibility issues or efforts label Mar 20, 2024
Carreau added a commit to Carreau/pydata-sphinx-theme that referenced this issue Apr 15, 2024
@Carreau
Do not generate dropdown in sidebar.
040765a 
This should fix pydata#1735, it is complementary to pydata#1564 but with a different
approach.

Instead of generating the same navbar as the fullpage width one, it
generate one with no dropdowns, with this, any css that tries to make
downtown looks like normal links in html becomes unnecessary.
@Carreau Carreau mentioned this issue Apr 15, 2024
Merged
Carreau added a commit to Carreau/pydata-sphinx-theme that referenced this issue Apr 23, 2024
@Carreau
Do not generate dropdown in sidebar.
2af9eb7 
This should fix pydata#1735, it is complementary to pydata#1564 but with a different
approach.

Instead of generating the same navbar as the fullpage width one, it
generate one with no dropdowns, with this, any css that tries to make
downtown looks like normal links in html becomes unnecessary.
Carreau added a commit to Carreau/pydata-sphinx-theme that referenced this issue Apr 23, 2024
@Carreau @gabalafou
Do not generate dropdown in sidebar.
e426f89 
This should fix pydata#1735, it is complementary to pydata#1564 but with a different
approach.

Instead of generating the same navbar as the fullpage width one, it
generate one with no dropdowns, with this, any css that tries to make
downtown looks like normal links in html becomes unnecessary.

Co-authored-by: gabalafou <gabriel@fouasnon.com>
Carreau added a commit to Carreau/pydata-sphinx-theme that referenced this issue May 2, 2024
@Carreau @gabalafou
Do not generate dropdown in sidebar.
13e38b8 
This should fix pydata#1735, it is complementary to pydata#1564 but with a different
approach.

Instead of generating the same navbar as the fullpage width one, it
generate one with no dropdowns, with this, any css that tries to make
downtown looks like normal links in html becomes unnecessary.

Co-authored-by: gabalafou <gabriel@fouasnon.com>
Carreau added a commit to Carreau/pydata-sphinx-theme that referenced this issue May 7, 2024
@Carreau @gabalafou
Do not generate dropdown in sidebar.
0ddc394 
This should fix pydata#1735, it is complementary to pydata#1564 but with a different
approach.

Instead of generating the same navbar as the fullpage width one, it
generate one with no dropdowns, with this, any css that tries to make
downtown looks like normal links in html becomes unnecessary.

Co-authored-by: gabalafou <gabriel@fouasnon.com>
drammock pushed a commit that referenced this issue May 8, 2024
@Carreau @gabalafou
Do not generate dropdown in sidebar. (#1771)
a31db4c 
* Do not generate dropdown in sidebar.

This should fix #1735, it is complementary to #1564 but with a different
approach.

Instead of generating the same navbar as the fullpage width one, it
generate one with no dropdowns, with this, any css that tries to make
downtown looks like normal links in html becomes unnecessary.

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* apply review

* Add failing test for dropdown sidebar

---------

Co-authored-by: gabalafou <gabriel@fouasnon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tag: accessibility Issues related to accessibility issues or efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not generate dropdown in sidebar. Carreau/pydata-sphinx-theme
2 participants
@gabalafou @trallard