Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: breadcrumbs truncated regardless of screen size #1568

Open
ivanov opened this issue Nov 17, 2023 · 1 comment
Open

regression: breadcrumbs truncated regardless of screen size #1568

ivanov opened this issue Nov 17, 2023 · 1 comment
Labels
kind: enhancement New feature or request tag: CSS CSS and SCSS related issues

Comments

@ivanov
Copy link

ivanov commented Nov 17, 2023

Good time of day to you! In jupyter/jupyter#702, we noticed that breadcrumbs get shortened very aggressively.

The change that introduced this was #1460 which was trying to address #1451, which affects mobile browsers (or very skinny viewports on desktop), but #1460 does so by cutting out letters without regard for the width of the viewport, which makes for some strange experiences when viewing using a laptop or desktop.

I think a more suitable alternative would be to revert #1460 and instead use something like CSS text-overflow and media queries to address and prevent overlap of breadcrumbs on small screens.

Compare the old 0.13.3
image

with the new 0.14.3
image

cc @12rambau and @drammock who implemented and merged #1460

@drammock
Copy link
Collaborator

thanks for raising this. text-overflow: ellipsis does look like a good option. Sadly I'm about to head on holiday for a week and wasn't able to tackle this beforehand. My apologies; hopefully another dev has time to look at it sooner. Otherwise I'll take a look early in December.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement New feature or request tag: CSS CSS and SCSS related issues
Projects
None yet
Development

No branches or pull requests

3 participants