Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Back to top" button blocks page content #1497

Closed
ivirshup opened this issue Oct 5, 2023 · 5 comments · Fixed by #1616
Closed

"Back to top" button blocks page content #1497

ivirshup opened this issue Oct 5, 2023 · 5 comments · Fixed by #1616
Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship needs: discussion Needs discussion before an implementation can be made needs: more information Needs more information from the author before we can move forward

Comments

@ivirshup
Copy link

ivirshup commented Oct 5, 2023

I'd like to report sort of a bug, sort of a feature request.

Demo:

Screen.Recording.2023-10-05.at.21.12.34.mov

When I get to the bottom of a page, the "Back to top" button blocks the last line of content. This makes it pretty hard to read.

I would suggest two possible solutions:

  • Allow turning this button off (I personally find it distracting, though I see how it could be useful on mobile)
  • Put the button somewhere else, like on the top of the page (as is done in both the mkdocs and furo examples shown in Scroll to top button to quickly jump to the top of the page #1126)
    • mkdocs and furo also have more muted buttons, which I think make the button less distracting.
@12rambau
Copy link
Collaborator

12rambau commented Oct 6, 2023

  • If you look at the associated PR thread, you'll see that using a bright button was actually an accessibility requirement. My initial design was using the background color: feat: add a scroll to top btn #1332
  • turning them off is a valuable request. I don't know why it's not already the case.
  • The positioning is also an accessibility request, it's closer to your thumb for mobile users which are the main beneficiaries of this.

@ivirshup
Copy link
Author

ivirshup commented Oct 6, 2023

The ability to turn it off would be great.

I think it could be nice if it were only enabled on mobile, but not sure how foolproof that is to implement. As a side note, I believe apple mobile devices have a built-in scroll to top when you tap the top of the screen.

I'm also not sure I get why it's important for this nav element to be on bottom, but not the other elements like the TOC or hamburger menu.

@12rambau 12rambau added needs: discussion Needs discussion before an implementation can be made needs: more information Needs more information from the author before we can move forward labels Oct 18, 2023
@Gouvernathor
Copy link

In addition to the ability to turn it off, which I would also greatly appreciate, I think it should be off by default on normal desktop, non-phone platforms. The ↖ (begin) key exists on most keyboards after all, so it's very weird to see a bright spot in the middle of the page when you don't actually need one in the first place.

@jamesdbrock
Copy link

I would love the ability to turn off “Back to Top”.

@al-rigazzi
Copy link

+1

I think the "Back to Top" button is not always needed and can be distracting, given its size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship needs: discussion Needs discussion before an implementation can be made needs: more information Needs more information from the author before we can move forward
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants