Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

our doc is build with Sphinx 5.3.0 #1441

Closed
12rambau opened this issue Sep 15, 2023 · 5 comments
Closed

our doc is build with Sphinx 5.3.0 #1441

12rambau opened this issue Sep 15, 2023 · 5 comments
Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship

Comments

@12rambau
Copy link
Collaborator

12rambau commented Sep 15, 2023 •
edited

I don't know if it's comming from us or one of our dependency but I think the theme documentation should be build with the latest compatible sphinx version.

https://pydata-sphinx-theme.readthedocs.io/en/stable/
@12rambau 12rambau added the impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship label Sep 18, 2023
@12rambau
Copy link
Collaborator Author

This is actually the source of the failed build of the documentation as last patch of @drammock in sphinx-contrib/youtube#56 is breaking with v5.3.0 of Sphinx

@drammock
Copy link
Collaborator

Yeah I just got that with my other packages today too. We should just bump our requirements to sphinx>=6

@12rambau 12rambau mentioned this issue Sep 18, 2023
Closed
@12rambau
Copy link
Collaborator Author

I'm going to experiment with a hard pin to 7 to unconver the one blocking the update.

@12rambau
Copy link
Collaborator Author

I find the culprit: executablebooks/MyST-NB#543

It's not advocating in favor of markdown for me ;-)

@drammock drammock mentioned this issue Sep 19, 2023
Merged
@12rambau 12rambau mentioned this issue Sep 27, 2023
Merged
@12rambau
Copy link
Collaborator Author

this was solved by #1482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unpin SPhinx version in documentation 12rambau/pydata-sphinx-theme
2 participants
@drammock @12rambau