From 6aa43a6c97dfc2a55dec24045a9d4900b935a4b2 Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Mon, 3 Jul 2023 13:42:49 -0500
Subject: [PATCH] add TODO

---
 src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js b/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
index a7b400693..eeb2b8f2b 100644
--- a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
+++ b/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
@@ -408,6 +408,9 @@ function showVersionWarningBanner(data) {
   }
   const preferredVersion = preferredEntries[0].version;
   const preferredURL = preferredEntries[0].url;
+  // TODO: make the below logic more forgiving:
+  //       - don't fail if version string not semVer-parsable
+  //       - if not semVer parsable make message more generic
   // if already on preferred version, nothing to do
   if (!version.includes("dev") && compare(version, preferredVersion, "=")) {
     return;