Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unintentional drop of character in HISTORY #7600

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Sep 25, 2023

Change Summary

The [^\n] leading character in the regex to add newlines was being unintentionally thrown away, this PR adjusts the re.sub call to re-emit that character.

Related issue number

N/A

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

@davidhewitt davidhewitt added the relnotes-ignore Omit this PR from the release notes. label Sep 25, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 25, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0893f7b
Status: ✅  Deploy successful!
Preview URL: https://6f5f1ba8.pydantic-docs2.pages.dev
Branch Preview URL: https://dh-relnotes.pydantic-docs2.pages.dev

View logs

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove the body = body.removeprefix("## What's Changed\n") here too, we had to remove it on 2.4 since it has the same heading level as the docs section itself.

Other option is to put it at h3 and all sub items as h4.

@samuelcolvin
Copy link
Member

please update.

@davidhewitt
Copy link
Contributor Author

added a follow-up commit, please review

@samuelcolvin samuelcolvin merged commit 1f59075 into main Sep 25, 2023
62 checks passed
@samuelcolvin samuelcolvin deleted the dh/relnotes branch September 25, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants