Fix mypy plugin for 1.4.0 #5927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
please review |
|
/CC: @dmontagu |
hramezani
reviewed
May 30, 2023
changes/5927-cdce8p.md
Outdated
| @@ -0,0 +1 @@ | |||
| Fix mypy plugin for v1.4.0 | |||
There was a problem hiding this comment.
This file is not needed for the main branch for now
|
Thanks @cdce8p. I left a comment. other than that LGTM please update |
Done. Removed it. please review |
hramezani
approved these changes
May 30, 2023
adriangb
pushed a commit
that referenced
this pull request
Jun 1, 2023
CheckmkCI
pushed a commit
to Checkmk/checkmk
that referenced
this pull request
Jun 22, 2023
Note that we need a pydantic version bump because of pydantic/pydantic#5927. Change-Id: I0537ca796d5d0b33e3cc4c6b7a5b27745da37ab7
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The next mypy release (1.4.0) will add a new required argument
defaultforTypeVarTypeandTypeVarExpr(in preparation for PEP 696 support).I'll open a custom cherry-pick PR next as this won't backport cleanly.
python/mypy#14872
Related issue number
--
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)
Selected Reviewer: @hramezani