Mark optional params as Optional

[JensHeinrich]

Mark parameters as Optional if they are
skip change file check

[JensHeinrich]

Yes, those annoy me because my editor is too angry

[JonathanPlasse]

You should remove implicit_optional = true from mypy configuration.

[JensHeinrich]

You should remove implicit_optional = true from mypy configuration.

Pretty sure that won't work as my editor is using pyright

[JensHeinrich]

You should remove implicit_optional = true from mypy configuration.

Pretty sure that won't work as my editor is using pyright

And I do like to do things correctly

[JonathanPlasse]

It should be removed because you are removing implicit optional.
This is present because there were implicit optional.

[JensHeinrich]

It should be removed because you are removing implicit optional. This is present because there were implicit optional.

I just had a look for this option, and according to this article mypy disallows implicit optional since version 0.99.
The implicit optional type has been removed from PEP 484 in python/peps#689

[hramezani]

Thanks @JensHeinrich