Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for comparison of AnyUrl objects #11082

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

alexprabhat99
Copy link
Contributor

@alexprabhat99 alexprabhat99 commented Dec 10, 2024

Change Summary

Related issue number

Fixes: #11069

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

Sorry, something went wrong.

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Dec 10, 2024
Copy link

codspeed-hq bot commented Dec 10, 2024

CodSpeed Performance Report

Merging #11082 will not alter performance

Comparing alexprabhat99:anyurl-comparison (378035e) with main (cc01258)

Summary

✅ 46 untouched benchmarks

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  networks.py
Project Total  

This report was generated by python-coverage-comment-action

@alexprabhat99
Copy link
Contributor Author

please review

@sydney-runkle
Copy link
Contributor

Thanks for the PR! Could you please also implement __le__, __gt__, and __ge__ and add corresponding tests? Thanks!

alexprabhat99 and others added 2 commits December 11, 2024 21:32

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@alexprabhat99
Copy link
Contributor Author

alexprabhat99 commented Dec 11, 2024

@sydney-runkle I have implemented __lt__, __gt__, __le__ and __ge__ and added corresponding tests. Thank you!

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@sydney-runkle sydney-runkle merged commit 6fa92d1 into pydantic:main Dec 11, 2024
52 checks passed
sydney-runkle pushed a commit that referenced this pull request Dec 18, 2024
@Viicos Viicos changed the title Fix for comaparison of AnyUrl objects Fix for comparison of AnyUrl objects Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison between AnyUrl objects is not working
2 participants