- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 83
Add env_nested_max_split setting #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+117
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:
- [Ss]ubstring
c18edb0
to
f552064
Compare
f552064
to
b773f0d
Compare
hramezani
reviewed
Feb 10, 2025
hramezani
reviewed
Feb 10, 2025
hramezani
reviewed
Feb 10, 2025
hramezani
reviewed
Feb 10, 2025
Thanks @gsakkis for this PR. I left some comments. |
Loading status checks…
a42676a
to
be78a03
Compare
hramezani
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New setting to limit the parsing of nested env vars split by
env_nested_delimiter
up to a given nesting depth.The main use case is to allow
env_nested_delimiter='_'
to work with fields that contain underscores, as proposed here.