Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve remaining deprecation warnings from PyO3 0.23 #1584

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

davidhewitt
Copy link
Contributor

Change Summary

This primarily removes uses of the ToPyObject trait in favour of IntoPyObject. The hardest bit was in the Input trait, which had previously used ToPyObject as a super-trait. Instead I now added a defaulted .to_object method on Input to minimise changes.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Sorry, something went wrong.

Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #1584 will improve performances by 10.25%

Comparing dh/final-0.23-fixups (36d414a) with main (d3a2f47)

Summary

⚡ 1 improvements
✅ 156 untouched benchmarks

Benchmarks breakdown

Benchmark main dh/final-0.23-fixups Change
test_frozenset_of_ints_duplicates_core 170.9 µs 155 µs +10.25%

@davidhewitt davidhewitt mentioned this pull request Dec 18, 2024
@davidhewitt
Copy link
Contributor Author

Will investigate the enum perf regressions before this is ready for merge.

@davidhewitt
Copy link
Contributor Author

Gonna ship 🚀

@davidhewitt davidhewitt merged commit 8758528 into main Jan 23, 2025
29 checks passed
@davidhewitt davidhewitt deleted the dh/final-0.23-fixups branch January 23, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant