Properly parse errorMessage key in error response #1526
Merged
+59
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adehad
requested changes
Nov 14, 2022
jira/resources.py
Outdated
Comment on lines
332
to
333
| raise_on_error(r) | ||
| error_list = parse_errors(r) | ||
| logging.error(error_list) |
There was a problem hiding this comment.
would we want to log the error and afterwards raise?
There was a problem hiding this comment.
it looks like raising the error should be removed completely as it will always raise for 400 HTTP response
previously it was raised in the json_loads and caught by get_error_list code
|
I've fixed the issue with unexpected error raising and added a test for errors parsing logic |
|
Thanks for the great quality PR ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent refactoring of the resilientsession module, we started to get empty text field in the JIRAError instances for the "Site temporary unavailable" errors.
This PR adds proper processing of such error responses and also adds consistency in errors processing in several parts of the lib