Fix bug preventing use of an int for issuetype in def create_issue #1445
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point a bug was introduced which prevents us from using `def create_issue(` to create an issue of a specific `issuetype`, when you want to indicate the issue type using an `int`. This is especially problematic for issue types where the string `issuetype` doesn't unambiguously identify the necessary issue type. This causes `def issue_type_by_name(` to raise a KeyError. There's currently a workaround (to use `def create_issues(`, which doesn't contain this bug.)
Jannik Meinecke (<jannik.meinecke@mercedes-benz.com>) on behalf of MBition GmbH. https://github.com/mercedes-benz/foss/blob/master/PROVIDER_INFORMATION.md
…-integer_issuetype
Jannik Meinecke (<jannik.meinecke@mercedes-benz.com>) on behalf of MBition GmbH. https://github.com/mercedes-benz/foss/blob/master/PROVIDER_INFORMATION.md
adehad
approved these changes
Aug 4, 2022
4 tasks
|
Thanks again @rynkk ! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #1273 by adding tests
Apparent bug causes supplied issuetype for
create_issueto always be treated as the name and not as the id, even if an integer was passed.nameshould be used if a string was passed, e.g.,"1234",idshould be used, if an integer was passed, e.g.,1234See issue #1274
The program was tested solely for our own use cases, which might differ from yours.
Jannik Meinecke jannik.meinecke@mercedes-benz.com on behalf of MBition GmbH.
https://github.com/mercedes-benz/foss/blob/master/PROVIDER_INFORMATION.md
Licensed under MIT