Fix various issues around X509_STORE_CTX reuse #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although OpenSSL happens to leave the errors in there on X509_STORE_CTX_cleanup, in no other OpenSSL API is accessing a cleaned up object meaningful. Do it in the other order.
The underscore-prefixed variables were not intended to be exposed as public API, so don't bother exposing it in the first place.
alex
reviewed
Nov 30, 2023
There's a lot of history with X509_STORE_CTX's somewhat messy transition from a stack-allocated type to a heap-allocated type. (This is why a double X509_STORE_CTX_init used to leak memory.) We can avoid all this mess by just making a new X509_STORE_CTX each time.
davidben
force-pushed
the
store-ctx-cleanup
branch
from
091bc1d
to
1454cd6
Compare
alex
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is three commits that probably should be reviewed separately. The first is a minimal fix for a weird behavior in pyOpenSSL: inspecting an X509_STORE_CTX after you have cleaned it up is pretty odd.
The next two rework X509StoreContext to just create a new X509_STORE_CTX for each verification, which avoids a whole lot of historical mess around X509_STORE_CTX's transition from being stack-allocated to heap-allocated in the OpenSSL API.