Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate X509Extension #1255

Merged
merged 1 commit into from Oct 17, 2023
Merged

Deprecate X509Extension #1255

merged 1 commit into from Oct 17, 2023

Conversation

facutuesca
Copy link
Contributor

Closes #1249

@reaperhulk
Copy link
Member

This needs changelog information and some prose in the documentation to give people instructions on how to do this going forward.

@facutuesca
Copy link
Contributor Author

facutuesca commented Oct 16, 2023 •
edited

This needs changelog information and some prose in the documentation to give people instructions on how to do this going forward.

@reaperhulk I added an entry to the changelog. I didn't see any mention in the documentation about the other deprecations, so I'm not sure where to put the prose. Do you have an example?

@reaperhulk
Copy link
Member

I don't have an example and the pyOpenSSL docs don't really lend themselves well to this. We already have a note at the top of the crypto module so I think that's okay for now.

@reaperhulk reaperhulk merged commit f2068f1 into pyca:main Oct 17, 2023
34 checks passed
@facutuesca facutuesca deleted the deprecate-x509extension branch October 18, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reaperhulk reaperhulk reaperhulk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate X509Extension and CRL APIs
2 participants
@facutuesca @reaperhulk