Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose X509_V_* constants #1202

Merged
merged 14 commits into from Apr 29, 2023
Merged

Conversation

itamarst
Copy link
Contributor

@itamarst itamarst commented Mar 27, 2023

Fixes #1201

The cryptography half of this is in pyca/cryptography#8626

Potential user hazard: As currently implemented, users of pyOpenSSL who depend on this may be setting up their users for weird errors if they happen to install cryptography 40. So possibly this should also include either:

  • Changing minimal required cryptography to 41, if/when Restore the x509 error verification codes cryptography#8626 is merged and v41 released.
  • Or, don't change the minimal version, but do change cryptography dependency to forbid version 40, so you'd get versions before and after.
  • Or, just assume this functionality is so obscure no one is likely to hit this in practice and do nothing.

@reaperhulk
Copy link
Member

I think we're going to backport and release those bindings in 40.0.2. I think I'd prefer to avoid bumping up the minimum version as well, so we'll want to be more explicit (40.0.0 and 40.0.1) for the conditional branch. Please also add a comment that says when we bump to a 41+ minimum we can remove the branch 😄

@itamarst
Copy link
Contributor Author

GitHub is being very laggy :( There's a fix for the flake issue that will show up in a minute or so.

@itamarst
Copy link
Contributor Author

Anyway, how's this?

src/OpenSSL/SSL.py Outdated Show resolved Hide resolved
src/OpenSSL/SSL.py Outdated Show resolved Hide resolved
@reaperhulk
Copy link
Member

Looks like this needs a rebase and addressing the outstanding comments. We're going to do a release in the next few days so this can land if it gets done!

@itamarst
Copy link
Contributor Author

Ugh got distracted and didn't finish this. Will try to get to this tomorrow or next week.

@itamarst
Copy link
Contributor Author

itamarst commented Apr 28, 2023

OK should be ready for review again, assuming CI passes.

@itamarst
Copy link
Contributor Author

Can't tell if the docs issue is my fault or not.

@alex
Copy link
Member

alex commented Apr 28, 2023

not related, I'll do a PR momentarily to fix it.

src/OpenSSL/SSL.py Outdated Show resolved Hide resolved
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, besides that this LGTM.

@itamarst
Copy link
Contributor Author

Addressed.

@itamarst itamarst requested a review from alex April 28, 2023 22:16
CHANGELOG.rst Outdated Show resolved Hide resolved
Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com>
@alex alex merged commit 2d94946 into pyca:main Apr 29, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Expose constants that are no longer available in latest cryptography
4 participants