Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for py39 environment #25

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Conversation

ngie-eign
Copy link

whitelist_externals was deprecated as of 3.18 and has been replaced by allowlist_externals. Use the new variable name to unbreak CI with py39.

Bump the minimum tox version to support the change (3.18 was where allowlist_externals was introduced).

Signed-off-by: Enji Cooper yaneurabeya@gmail.com

`whitelist_externals` was deprecated as of 3.18 and has been replaced by
`allowlist_externals`. Use the new variable name to unbreak CI with py39.

Bump the minimum tox version to support the change (3.18 was where
`allowlist_externals` was introduced).

Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
Copy link

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! Looks great! Thank you

@droideck droideck merged commit 2590ba6 into pyasn1:main Feb 23, 2023
@ngie-eign ngie-eign deleted the fix-py39-tox-ci branch February 24, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants