Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back EOL Python support for 0.5.1 release #44

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

droideck
Copy link

Add missing settings for Python 12 support

Add missing settings for Python 12 support
@droideck droideck requested a review from tiran September 25, 2023 20:17
@lextm
Copy link

lextm commented Sep 25, 2023

Thank you for your effort on this PR. However, I noticed a few confusing places:

  • The title of this PR mentions bringing back versions 2.7, 3.6, and 3.7, yet the description references the addition of 3.12. Could you clarify this discrepancy?
  • The initial PR Remove support for EOL Python 2 #40 seemed to take a reasonable step by discontinuing support for EOL releases. Could you explain the rationale behind reintroducing these versions in the current PR?

It would be beneficial for followers of this project if all PRs were a bit clearer in their intentions so that the community understand and support the project's direction more effectively.

@droideck
Copy link
Author

Thank you for your effort on this PR. However, I noticed a few confusing places:

  • The title of this PR mentions bringing back versions 2.7, 3.6, and 3.7, yet the description references the addition of 3.12. Could you clarify this discrepancy?

It's in the second line of the PR/commit message.

  • The initial PR Remove support for EOL Python 2 #40 seemed to take a reasonable step by discontinuing support for EOL releases. Could you explain the rationale behind reintroducing these versions in the current PR?

As mentioned in the title, it's for 0.5.1 release.
We'll EOL Python 2 in the next major version (0.6.0)

@lextm
Copy link

lextm commented Sep 25, 2023

@droideck thanks for sharing the information. Now it's clear.

@droideck droideck merged commit 16fde23 into pyasn1:main Nov 1, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants