BUG: Avoid exceeding recursion depth when retrieving image mode #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2251 +/- ##
=======================================
Coverage 94.44% 94.45%
=======================================
Files 43 43
Lines 7621 7624 +3
Branches 1502 1503 +1
=======================================
+ Hits 7198 7201 +3
Misses 261 261
Partials 162 162
☔ View full report in Codecov by Sentry. |
|
Thank you @stefan6419846 for investigating that issue + creating a PDF that would cause the issue 🙏 |
MartinThoma
added a commit
that referenced
this pull request
Oct 10, 2023
## What's new ### Bug Fixes (BUG) - Avoid exceeding recursion depth when retrieving image mode (#2251) by @stefan6419846 ### Maintenance (MAINT) - Bump sample-files by @MartinThoma [Full Changelog](3.16.3...3.16.4)
|
I've just created a new release for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, retrieving the image mode could lead to an infinite loop when nested color spaces have been used ("RecursionError: maximum recursion depth exceeded in comparison"). This has been fixed by limiting the default depth which is allowed.