Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined Constant when running via Rake #332

Closed
chelnak opened this issue Oct 25, 2022 · 0 comments · Fixed by #333
Closed

Undefined Constant when running via Rake #332

chelnak opened this issue Oct 25, 2022 · 0 comments · Fixed by #333
Labels
bug

Comments

@chelnak
Copy link
Contributor

chelnak commented Oct 25, 2022

Describe the Bug

When running puppet strings generate via the Rake tasks you may get an Undefined Constant error.

This is caused by the compact module nesting style added in 3.0.

f68b2be#diff-437c04dd59b7bc0942ed0926bcb8e40a007e3f4f31d6e57d79a1ff78c7e662a1L6

Expected Behavior

It should successfully generate a reference file

Steps to Reproduce

Steps provided by @bastelfreak

git clone git@github.com:voxpupuli/puppet-nftables.git; cd  puppet-nftables; bundle install --path .vendor/ --without system_tests:development --jobs=$(nproc); bundle exec rake reference
@chelnak chelnak added the bug label Oct 25, 2022
chelnak added a commit that referenced this issue Oct 25, 2022
@chelnak
(GH-332) Ensure PuppetStrings is loaded for tasks

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: ED11605AA22B0C48
Learn about vigilant mode
0c860b4 
Prior to this commit users would recieve an Undefined Constant error
when attempting to generate a reference file via the provided Rake
tasks.

This was caused by the compact testing style for modules added in v3.0.

In this case the parent, PuppetStrings is not properly loaded before
Tasks. As a result the error above is caused.

This commit adds a new module declaration to tasks.rb that will ensure
that the PuppetStrings is properly loaded.
chelnak added a commit that referenced this issue Oct 25, 2022
@chelnak
(GH-332) Ensure PuppetStrings is loaded for tasks

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: ED11605AA22B0C48
Learn about vigilant mode
0292153 
Prior to this commit users would receive an Undefined Constant error
when attempting to generate a reference file via the provided Rake
tasks.

This was caused by the compact testing style for modules added in v3.0.

In this case the parent, PuppetStrings is not properly loaded before
Tasks. As a result the error above is caused.

This commit adds a new module declaration to tasks.rb that will ensure
that the PuppetStrings is properly loaded.
LukasAud added a commit that referenced this issue Oct 25, 2022
@LukasAud
Merge pull request #333 from puppetlabs/GH-332-ensure_module_is_loaded
55e3091 
(GH-332) Ensure PuppetStrings is loaded for tasks
chelnak added a commit that referenced this issue Oct 25, 2022
@chelnak
(GH-332) Bump gem version to 3.0.1
77a1785
pmcmaw added a commit that referenced this issue Oct 25, 2022
@pmcmaw
Merge pull request #334 from puppetlabs/GH-332-bump_gem_version
8eee747 
(GH-332) Bump gem version to 3.0.1
@chelnak chelnak linked a pull request Oct 26, 2022 that will close this issue
(GH-332) Ensure PuppetStrings is loaded for tasks #333
Merged
@chelnak chelnak closed this as completed Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(GH-332) Ensure PuppetStrings is loaded for tasks puppetlabs/puppet-strings
1 participant
@chelnak