fix: increase the default protocol timeout #9928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/bump-default-protocol-timeout
branch
from
75c7bc3
to
84c5d7a
Compare
Lightning00Blade
approved these changes
Mar 28, 2023
OrKoN
force-pushed
the
orkon/bump-default-protocol-timeout
branch
from
84c5d7a
to
eb283f8
Compare
This PR increases the protocol timeout to be less likely triggered by normal operations but still indicate errors in case of backend issues instead of waiting forever. Unfortunately, the current script evaluation API does not allow configuring the timeouts per operations and it's not possible to change this due to variadic arguments accepted in evaluate and evaluateHandle. We could consider exposing new methods which also accept a timeout but for now let's see if increasing the connection timeout is good enough. Issue #9927
OrKoN
force-pushed
the
orkon/bump-default-protocol-timeout
branch
from
eb283f8
to
df731f1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the protocol timeout to be less likely triggered by normal operations but still indicate errors in case of backend issues instead of waiting forever. Unfortunately, the current script evaluation API does not allow configuring the timeouts per operations and it's not possible to change this due to variadic arguments accepted in evaluate and evaluateHandle. We could consider exposing new methods which also accept a timeout but for now let's see if increasing the connection timeout is good enough. Also, updated the error message with the info on how to increase the timeout.
Issue #9927