chore: skip building on install #9902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/skip-recompile-on-install
branch
from
3446afb
to
f8247f0
Compare
Currently, we try to compile the installation script during `npm i` in the development repository. This is a fragile process because the build might not succeed during the installation (missing packages) and it adds to the installation time. This PR removes the build step and instead recommends running the install after a build.
OrKoN
force-pushed
the
orkon/skip-recompile-on-install
branch
from
f8247f0
to
543b2b2
Compare
Lightning00Blade
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we try to compile the installation script during
npm iin the development repository. This is a fragile process because the build might not succeed during the installation (missing packages) and it adds to the installation time. This PR removes the build step and instead recommends running the install after a build.