fix: waitForNavigation issue with aborted events #9883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
Mar 21, 2023
OrKoN
force-pushed
the
fix-waitfornavigation
branch
from
7b78c3c
to
5d98b9b
Compare
Merged
|
Nice, thanks for this @Lightning00Blade and @OrKoN ! 🙌 From this PR from the bot it looks like it will be released in |
|
This commit seems to result in continuously adding new request/response event listeners, ultimately leading to memory leaks. Please confirm this, thank you. @Lightning00Blade @OrKoN |
Here is the snapshot：#5893 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9881, fixes #8383.
The issue seem to be that we don't listen to all the possible event for Request/Response so we never try to see if there are no requests.
@OrKoN Let's take a closer look together to see if there are other "unhappy" paths that need to handled.