fix: implement protocol-level timeouts #9877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/timeouts-for-cdp
branch
3 times, most recently
from
956833c
to
547b76a
Compare
OrKoN
commented
Mar 17, 2023
OrKoN
force-pushed
the
orkon/timeouts-for-cdp
branch
6 times, most recently
from
e3d9c57
to
b349a21
Compare
OrKoN
force-pushed
the
orkon/timeouts-for-cdp
branch
from
b349a21
to
602bed6
Compare
jrandolf
approved these changes
Mar 21, 2023
jrandolf
suggested changes
Mar 21, 2023
This PR implements timeouts for the protocol-level calls and a new launch/connect option called protocolTimeout. The default value will be 30s and there is an option to disable it by providing an undefined/negative/0 value. Drive-by: refactored callbacks to encapsulate timeouts and reduce duplication. Also, marked ConnectionCallback as internal as there was no way to use it externally anyway. Closes #9801 For follow-ups: we should probably mark connection as an internal class (but we need to deprecate it first and see if there are users for it) and changes the constructor parameters to accept an object instead of positional arguments.
OrKoN
force-pushed
the
orkon/timeouts-for-cdp
branch
from
602bed6
to
3daeae7
Compare
jrandolf
approved these changes
Mar 21, 2023
Merged
1 task
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements timeouts for the protocol-level calls and a new launch/connect option called
protocolTimeout. The default value will be 30s and there is an option to disable it by providing an undefined/negative/0 value.Drive-by: refactored callbacks to encapsulate timeouts and reduce duplication. Also, marked ConnectionCallback as internal as there was no way to use it externally anyway.
Closes #9801
For follow-ups: 1) we should probably mark connection as an internal class (but we need to deprecate it first and see if there are users for it) and changes the constructor parameters to accept an object instead of positional arguments. 2) we could probably do smth better for the original message/protocol error things.