refactor: remove EventSubscription #12277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lightning00Blade
force-pushed
the
removeEventListenerClass
branch
from
2347dfe
to
eeed3a7
Compare
OrKoN
approved these changes
Apr 19, 2024
Lightning00Blade
force-pushed
the
removeEventListenerClass
branch
from
27cb6e9
to
f9f90af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we have a single way of adding EventEmitter to disposable stacks.
The
EventSubscriptionis still used on thePipeTransport, and our higher order EventEmitter does not support common EventEmitter. Will refactor in another PR and dropEventSubscription.