refactor: extract toggling of Network Interception #12266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.#extraHTTPHeaders = {}; | ||
| for (const key of Object.keys(extraHTTPHeaders)) { | ||
| const value = extraHTTPHeaders[key]; | ||
| async setExtraHTTPHeaders(headers: Record<string, string>): Promise<void> { |
There was a problem hiding this comment.
Ops this was suppose to be separate, tell me if you want me to extract.
But we should should change the state only after assertion is completed.
Lightning00Blade
force-pushed
the
simplify-toggling-page-interception
branch
from
0a7f44a
to
e731e12
Compare
OrKoN
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.