Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove NetworkServiceInProcess2 set by default #12261

Merged
merged 1 commit into from Apr 12, 2024

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Apr 12, 2024

Puppeteer has relied on this flag for a long time but it looks like it is not required anymore and it might lead to crashes in the latest versions of Chrome for desktop. This CL removes the flag.

Issue #12257

@OrKoN OrKoN force-pushed the orkon/remove-NetworkServiceInProcess2 branch from 1b80d98 to 75fcd42 Compare April 12, 2024 08:28
@OrKoN OrKoN changed the title fix: remove NetworkServiceInProcess2 fix: remove NetworkServiceInProcess2 set by default Apr 12, 2024
@OrKoN OrKoN force-pushed the orkon/remove-NetworkServiceInProcess2 branch from 75fcd42 to 33fdd85 Compare April 12, 2024 08:31
@OrKoN OrKoN added the full-ci label Apr 12, 2024
@OrKoN OrKoN marked this pull request as ready for review April 12, 2024 08:38
@OrKoN OrKoN enabled auto-merge (squash) April 12, 2024 08:54
@OrKoN OrKoN disabled auto-merge April 12, 2024 08:55
@OrKoN OrKoN enabled auto-merge (squash) April 12, 2024 08:55
@OrKoN OrKoN merged commit 4f659b0 into main Apr 12, 2024
98 of 100 checks passed
@OrKoN OrKoN deleted the orkon/remove-NetworkServiceInProcess2 branch April 12, 2024 09:00
@release-please release-please bot mentioned this pull request Apr 12, 2024
OrKoN added a commit that referenced this pull request Apr 12, 2024
Puppeteer has relied on this flag for a [long time](#3738) but it looks like it is not required anymore and it might lead to crashes in the latest versions of Chrome for desktop. This CL removes the flag.

Issue #12257
This was referenced Apr 12, 2024
OrKoN pushed a commit that referenced this pull request Apr 15, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>browsers: 2.2.2</summary>

##
[2.2.2](browsers-v2.2.1...browsers-v2.2.2)
(2024-04-15)


### Bug Fixes

* remove NetworkServiceInProcess2 set by default
([#12261](#12261))
([ff4f70f](ff4f70f)),
closes [#12257](#12257)
</details>

<details><summary>puppeteer: 22.6.5</summary>

##
[22.6.5](puppeteer-v22.6.4...puppeteer-v22.6.5)
(2024-04-15)


### Miscellaneous Chores

* **puppeteer:** Synchronize puppeteer versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * puppeteer-core bumped from 22.6.4 to 22.6.5
    * @puppeteer/browsers bumped from 2.2.1 to 2.2.2
</details>

<details><summary>puppeteer-core: 22.6.5</summary>

##
[22.6.5](puppeteer-core-v22.6.4...puppeteer-core-v22.6.5)
(2024-04-15)


### Bug Fixes

* remove NetworkServiceInProcess2 set by default
([#12261](#12261))
([ff4f70f](ff4f70f)),
closes [#12257](#12257)
* use setImmediate to reduce flakiness when processing events
([#12264](#12264))
([73403b3](73403b3))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @puppeteer/browsers bumped from 2.2.1 to 2.2.2
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants