fix: retain stale main frame for longer #12225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
changed the title
OrKoN
force-pushed
the
orkon/main-frame-issue
branch
2 times, most recently
from
9680c53
to
291f523
Compare
Lightning00Blade
approved these changes
Apr 8, 2024
OrKoN
force-pushed
the
orkon/main-frame-issue
branch
from
291f523
to
07d74a2
Compare
Although #11246 has no reproducible example and the root cause might be accessing main frames while they are navigating, this PR adds a workaround to retain a potentially stale main frame to prevent assertion errors.
OrKoN
force-pushed
the
orkon/main-frame-issue
branch
from
07d74a2
to
8d7ab3f
Compare
Closed
|
@OrKoN thanks. I will update my testsuite to the puppeteer version that contains that fix when ready, and return for a feedback. How could i know wich puppeteer version contains that fix? thankyou. |
|
@andreabisello it will be in the next release, you can follow the linked release PR for that |
Merged
|
There are 0 tests. Is it enough for this fix? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although #11246 has no reproducible example and the root cause might be the access to main frames while they are navigating, this PR adds a workaround to retain a potentially stale main frame to prevent assertion errors.
Bug: #11246