fix: wait for fonts before pdf printing #12175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/wait-for-fonts
branch
from
d3d1edd
to
5932a9f
Compare
Lightning00Blade
approved these changes
Apr 2, 2024
OrKoN
force-pushed
the
orkon/wait-for-fonts
branch
from
5932a9f
to
0de168f
Compare
Merged
|
Hi @OrKoN. I wonder if we should actually get this added to the WebDriver specifications. It sounds like an important thing to do. |
|
@whimboo perhaps but it is easy to implement on the client side. I decided to enable this by default to learn if there are use cases where waiting for fonts is not desired. It could inform our decision as to if this needs to be optional. |
|
Sounds good. In case it would make things more stable please inform us or as usual file an issue for BiDi yourself. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a command to always wait for the web fonts readiness before generating a PDF.
Closes #3183