Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reload should not resolve early on fragment navigations #12119

Merged
merged 1 commit into from Mar 21, 2024

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Mar 21, 2024

Reload would always trigger a new document navigation so it should wait for it instead of potential intermediate same-document navigations.

Closes #10435

@OrKoN OrKoN requested a review from jrandolf March 21, 2024 09:47
@OrKoN OrKoN changed the title fix: reload should not trip on fragment navigations fix: reload should not resolve early on fragment navigations Mar 21, 2024
@OrKoN OrKoN force-pushed the orkon/fix-reload branch 2 times, most recently from 88d97a5 to 9a29b19 Compare March 21, 2024 10:10
Copy link
Contributor

@jrandolf jrandolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[redacted]

@OrKoN OrKoN enabled auto-merge (squash) March 21, 2024 10:53
@OrKoN OrKoN merged commit d476031 into main Mar 21, 2024
38 checks passed
@OrKoN OrKoN deleted the orkon/fix-reload branch March 21, 2024 10:54
@release-please release-please bot mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Page.reload() Destroys execution context on certain websites
2 participants