chore: refactor exposed function for BiDi #11976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
jrandolf/exposed-function
branch
4 times, most recently
from
f633dca
to
301ebc8
Compare
jrandolf
force-pushed
the
jrandolf/exposed-function
branch
2 times, most recently
from
9c4baba
to
c593b8d
Compare
OrKoN
reviewed
Feb 22, 2024
OrKoN
reviewed
Feb 22, 2024
OrKoN
approved these changes
Feb 22, 2024
jrandolf
force-pushed
the
jrandolf/exposed-function
branch
from
a18d8a0
to
bfa18f5
Compare
jrandolf
force-pushed
the
jrandolf/exposed-function
branch
from
bfa18f5
to
c5aabf7
Compare
|
Looks like some test fail in Firefox |
jrandolf
force-pushed
the
jrandolf/exposed-function
branch
7 times, most recently
from
627a3f7
to
7d7d41a
Compare
Looks like that test wasn't testing what it needed. We don't guarantee that exposed function calls in a preload script will resolve before navigation finishes. I've fixed the test to actually reflect what its title states. |
jrandolf
force-pushed
the
jrandolf/exposed-function
branch
from
7d7d41a
to
12fdd40
Compare
jrandolf
force-pushed
the
jrandolf/exposed-function
branch
from
12fdd40
to
f8c326b
Compare
OrKoN
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using one channel instead of three.
Bug: #11981