Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bidi): implement UserContexts #11784

Merged
merged 10 commits into from Jan 31, 2024
Merged

feat(bidi): implement UserContexts #11784

merged 10 commits into from Jan 31, 2024

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Jan 30, 2024

This PR implements https://w3c.github.io/webdriver-bidi/#user-contexts for WebDriver BiDi protocol in Puppeteer.

@sadym-chromium
Copy link
Collaborator

User context should be passed to browsingContext.create in BrowserContext.newPage method

@OrKoN OrKoN force-pushed the orkon/user-contexts branch 2 times, most recently from 09a4b86 to 597dd6d Compare January 30, 2024 11:46
@OrKoN OrKoN added the full-ci label Jan 30, 2024
@OrKoN OrKoN marked this pull request as ready for review January 30, 2024 16:08
@OrKoN
Copy link
Collaborator Author

OrKoN commented Jan 30, 2024

@sadym-chromium I think this is mostly ready but I will go over the change to see if there could be any flakiness

@OrKoN OrKoN merged commit 2930a70 into main Jan 31, 2024
38 checks passed
@OrKoN OrKoN deleted the orkon/user-contexts branch January 31, 2024 08:22
@release-please release-please bot mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants