Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update WebDriver BiDi documentation #11536

Merged
merged 6 commits into from Dec 13, 2023
Merged

docs: update WebDriver BiDi documentation #11536

merged 6 commits into from Dec 13, 2023

Conversation

jecfish
Copy link
Contributor

@jecfish jecfish commented Dec 13, 2023

  • include Firefox announcement in the doc
  • polishing

@jecfish jecfish changed the title Update WebDriver BiDi documentation [WIP] Update WebDriver BiDi documentation Dec 13, 2023
@jecfish jecfish changed the title [WIP] Update WebDriver BiDi documentation Update WebDriver BiDi documentation Dec 13, 2023
@jecfish jecfish changed the title Update WebDriver BiDi documentation docs: Update WebDriver BiDi documentation Dec 13, 2023
jecfish
jecfish commented Dec 13, 2023
View reviewed changes
docs/webdriver-bidi.md Outdated Show resolved Hide resolved
@jecfish
Copy link
Contributor Author

jecfish commented Dec 13, 2023

@mathiasbynens PTAL

jrandolf
jrandolf approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@jrandolf jrandolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but everything else is fine.

docs/webdriver-bidi.md Outdated Show resolved Hide resolved
@jrandolf jrandolf changed the title docs: Update WebDriver BiDi documentation docs: update WebDriver BiDi documentation Dec 13, 2023
mathiasbynens
mathiasbynens approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lightning00Blade Lightning00Blade merged commit af9aebe into puppeteer:main Dec 13, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@jrandolf jrandolf jrandolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jecfish @mathiasbynens @jrandolf @Lightning00Blade