fix: remove import cycle in query handlers #11234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/remove-aria-query-handler-cycle
branch
2 times, most recently
from
ad496f6
to
76e6611
Compare
I could only think of a way to check using a symbol. This satisfies TypeScript, the runtime and does not cause cycles in the import graph.
OrKoN
force-pushed
the
orkon/remove-aria-query-handler-cycle
branch
from
76e6611
to
c780dde
Compare
Lightning00Blade
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
An other option would be this TypeScript Playground.
But I am not sure it's better the issue is you can not use x[Y] to narrow down a type, but with Symbol brackets are always needed.
TS issue is from 2016, main problem seems to be performance - microsoft/TypeScript#10530
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could only think of a way to check using a symbol. This satisfies TypeScript, the runtime and does not cause cycles in the import graph.