chore: merge locators in a single file #11233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the locators folder is structures in such way that it leads to cyclic dependencies that do not work safely in all enviroments. This PR merges locators in a single file to enable cycle detection lint rule. Afterwards, we can move it to separate files once the cycle issue is resolved.
Lightning00Blade
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the locators folder is structures in such way that it leads to cyclic dependencies that do
not work safely in all enviroments. This PR merges locators in a single file to enable cycle detection lint rule. Afterwards, we can move it to separate files once the cycle issue is resolved.